Needs Triage Bug Report - Teambuilder

[tofa]

What type of bug are you reporting? Teambuilder

What is the bug?
Expected behavior: When fetching an uploaded Box from the teams database, it appears as a Box in the Teambuilder panel, with properties associated with Boxes such as increased capacity.

Observed behavior: When fetching an uploaded Box from the teams database, it appears as a normal Team (with possibly > 6 pokemon) in the Teambuilder panel.

Why is this an issue? It prevents the PS Client from being able to differentiate between remote-fetched Boxes and Teams. Currently not a problem today, but if other PS Client features want to make use of this differentiation, this could become problematic.

Did some debugging from the PS Client POV in the Browser console. After performing the below steps, Storage.teams[<fetchedTeamIndex>].capacity is undefined for Boxes fetched from the remote database, as opposed to 24 which my other non-remote Boxes have. It also seems that my non-remote Boxes have "-box" appended to the format in some internal representations, e.g "gen9ou-box". Not sure if that helps but that's what I found!

Below is a screenshot of observed behavior after replicated steps, where the top entry was originally a Box:

Screenshot

Are you able to replicate it? If so, how?
Yes:

1. Create a new Box with the format set to "Gen 9 OU"
2. Paste in the following sets for example (20 in this example, but any number < 24 should lead to the same behavior):
   
   Import

   Hydrapple @ Heavy-Duty Boots Ability: Sticky Hold
   Tera Type: Ice
   EVs: 244 HP / 252 Def / 12 SpD
   Bold Nature
   IVs: 0 Atk / 27 Spe
   - Recover
   - Body Press
   - Giga Drain
   - Tera Blast
   
   Blissey @ Heavy-Duty Boots
   Ability: Natural Cure
   Tera Type: Water
   EVs: 4 HP / 252 Def / 252 SpD
   Calm Nature
   IVs: 0 Atk / 30 Spe
   - Soft-Boiled
   - Calm Mind
   - Stealth Rock
   - Seismic Toss
   
   Dondozo @ Heavy-Duty Boots
   Ability: Unaware
   Tera Type: Fighting
   EVs: 252 HP / 252 Def / 4 SpD
   Impish Nature
   - Waterfall
   - Rest
   - Sleep Talk
   - Curse
   
   Clodsire @ Heavy-Duty Boots
   Ability: Unaware
   Tera Type: Steel
   EVs: 116 HP / 148 Def / 244 SpD
   Careful Nature
   - Recover
   - Amnesia
   - Poison Sting
   - Bulldoze
   
   Alomomola @ Heavy-Duty Boots
   Ability: Regenerator
   Tera Type: Ghost
   EVs: 12 HP / 252 Def / 244 SpD
   Relaxed Nature
   IVs: 0 Spe
   - Wish
   - Protect
   - Whirlpool
   - Flip Turn
   
   Gliscor @ Toxic Orb
   Ability: Poison Heal
   Tera Type: Ghost
   EVs: 244 HP / 252 Def / 12 SpD
   Impish Nature
   - Protect
   - Knock Off
   - Spikes
   - Poison Jab
   
   Gliscor @ Toxic Orb
   Ability: Poison Heal
   Tera Type: Ghost
   EVs: 244 HP / 252 Def / 12 SpD
   Impish Nature
   - Protect
   - Knock Off
   - Toxic
   - Spikes
   
   Blissey @ Heavy-Duty Boots
   Ability: Natural Cure
   Tera Type: Water
   EVs: 4 HP / 252 Def / 252 SpD
   Calm Nature
   IVs: 0 Atk
   - Soft-Boiled
   - Seismic Toss
   - Calm Mind
   - Protect
   
   Dondozo @ Heavy-Duty Boots
   Ability: Unaware
   Tera Type: Fighting
   EVs: 252 HP / 252 Def / 4 SpD
   Impish Nature
   - Avalanche
   - Body Press
   - Rest
   - Sleep Talk
   
   Clodsire @ Heavy-Duty Boots
   Ability: Unaware
   Tera Type: Dark
   EVs: 140 HP / 124 Def / 244 SpD
   Careful Nature
   - Poison Jab
   - Amnesia
   - Recover
   - Earthquake
   
   Alomomola @ Heavy-Duty Boots
   Ability: Regenerator
   Tera Type: Steel
   EVs: 12 HP / 252 Def / 244 SpD
   Relaxed Nature
   IVs: 0 Spe
   - Scald
   - Wish
   - Protect
   - Flip Turn
   
   Talonflame @ Heavy-Duty Boots
   Ability: Flame Body
   Tera Type: Grass
   EVs: 252 HP / 204 Def / 52 Spe
   Bold Nature
   IVs: 0 Atk
   - Flamethrower
   - Defog
   - Will-O-Wisp
   - Roost
   
   Meowscarada @ Heavy-Duty Boots
   Ability: Protean
   Tera Type: Ice
   EVs: 252 Atk / 4 SpD / 252 Spe
   Jolly Nature
   - Knock Off
   - Flower Trick
   - Triple Axel
   - Low Kick
   
   Gliscor @ Toxic Orb
   Ability: Poison Heal
   Tera Type: Dragon
   EVs: 252 HP / 252 Def / 4 SpD
   Impish Nature
   - Protect
   - Toxic
   - Spikes
   - Earthquake
   
   Clefable @ Leftovers
   Ability: Magic Guard
   Tera Type: Fire
   EVs: 252 HP / 252 Def / 4 SpD
   Bold Nature
   IVs: 0 Atk
   - Stealth Rock
   - Moonblast
   - Wish
   - Protect
   
   Slowking-Galar @ Heavy-Duty Boots
   Ability: Regenerator
   Tera Type: Water
   EVs: 252 HP / 4 Def / 252 SpD
   Sassy Nature
   IVs: 0 Atk / 0 Spe
   - Future Sight
   - Chilly Reception
   - Slack Off
   - Sludge Bomb
   
   Clodsire @ Heavy-Duty Boots
   Ability: Unaware
   Tera Type: Steel
   EVs: 252 HP / 4 Def / 252 SpD
   Sassy Nature
   IVs: 0 Spe
   - Toxic
   - Amnesia
   - Recover
   - Earthquake
   
   Dondozo @ Heavy-Duty Boots
   Ability: Unaware
   Tera Type: Fighting
   EVs: 252 HP / 252 Def / 4 SpD
   Impish Nature
   - Liquidation
   - Body Press
   - Sleep Talk
   - Rest
   
   Dragapult @ Heavy-Duty Boots
   Ability: Infiltrator
   Tera Type: Ghost
   EVs: 4 Def / 252 SpA / 252 Spe
   Timid Nature
   - Will-O-Wisp
   - U-turn
   - Hex
   - Draco Meteor
   
   Gliscor @ Toxic Orb
   Ability: Poison Heal
   Tera Type: Ghost
   EVs: 244 HP / 252 Def / 12 SpD
   Impish Nature
   - Protect
   - Knock Off
   - Spikes
   - U-turn
3. Upload the team to remote teams database
4. Delete team locally
5. Refresh the page
6. Go into Teambuilder and inspect the re-fetched team
7. The re-fetched team will not look like a Box in the Teambuilder (and will have undefined capacity)

Many thanks for looking into this!